Skip to content

Conversation

@nuria1110
Copy link
Contributor

@nuria1110 nuria1110 commented Nov 3, 2025

Proposed behaviour

Deprecates current version of RadioButton and RadioButtonGroup.

Adds new version of RadioButton and RadioButtonGroup with audit changes, located in the __next__ directory.
To achieve this new versions of internal components of Fieldset and CheckableInput have also been added.

RadioButtonGroup:

  • Replace legendHelp with legendHint.
  • Remove legacy tooltip validation & related props.
  • Remove inline legend.
  • Add size prop with values "small", "medium" and "large".
  • Common props to be passed directly through the group component.
  • Update styles.

RadioButton:

  • Replace labelHelp & fieldHelp with inputHint.
  • Remove validation & related props.
  • Add progressive disclosure via the conditionalContent prop.

Current behaviour

RadioButton and RadioButtonGroup are not aligned with the DS.

Checklist

  • Commits follow our style guide
  • Related issues linked in commit messages if required
  • Screenshots are included in the PR if useful
  • All themes are supported if required
  • Unit tests added or updated if required
  • Playwright automation tests added or updated if required
  • Storybook added or updated if required
  • Translations added or updated (including creating or amending translation keys table in storybook) if required
  • Typescript d.ts file added or updated if required
  • Related docs have been updated if required

QA

  • Tested in provided StackBlitz sandbox/Storybook
  • Add new Playwright test coverage if required
  • Carbon implementation matches Design System/designs
  • UI Tests GitHub check reviewed if required

Additional context

Testing instructions

DipperTheDan
DipperTheDan previously approved these changes Nov 11, 2025
@Parsium Parsium self-requested a review November 12, 2025 15:33
Copy link
Contributor

@Parsium Parsium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one minor comment from me, nice work @nuria1110 👍🏼

Adds new `RadioButton` and `RadioButtonGroup`, located in the `__next__` directory.
This new version applies new DS changes and new design tokens.

`RadioButton` and `RadioButtonGroup` with legacy styles and validation have been deprecated.
@nuria1110 nuria1110 force-pushed the radio-button-audit branch 2 times, most recently from ba2bef4 to b371d74 Compare November 14, 2025 15:44
DipperTheDan
DipperTheDan previously approved these changes Nov 14, 2025
Parsium
Parsium previously approved these changes Nov 14, 2025
@nuria1110 nuria1110 dismissed stale reviews from Parsium and DipperTheDan via ce51f5a November 17, 2025 09:55
Parsium
Parsium previously approved these changes Nov 17, 2025
DipperTheDan
DipperTheDan previously approved these changes Nov 17, 2025
@harpalsingh harpalsingh marked this pull request as ready for review November 17, 2025 14:59
@harpalsingh harpalsingh requested review from a team as code owners November 17, 2025 14:59
@nuria1110 nuria1110 dismissed stale reviews from DipperTheDan and Parsium via 974e076 November 18, 2025 14:25
@nuria1110 nuria1110 marked this pull request as draft November 21, 2025 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

4 participants