-
Notifications
You must be signed in to change notification settings - Fork 86
feat(radio-button, radio-button-group): audit changes #7608
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
nuria1110
wants to merge
8
commits into
master
Choose a base branch
from
radio-button-audit
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+2,470
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DipperTheDan
previously approved these changes
Nov 11, 2025
Parsium
reviewed
Nov 13, 2025
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one minor comment from me, nice work @nuria1110 👍🏼
Adds new `RadioButton` and `RadioButtonGroup`, located in the `__next__` directory. This new version applies new DS changes and new design tokens. `RadioButton` and `RadioButtonGroup` with legacy styles and validation have been deprecated.
ba2bef4 to
b371d74
Compare
DipperTheDan
previously approved these changes
Nov 14, 2025
Parsium
previously approved these changes
Nov 14, 2025
src/components/radio-button/radio-button-group/radio-button-group.component.tsx
Show resolved
Hide resolved
b371d74 to
ce51f5a
Compare
Parsium
previously approved these changes
Nov 17, 2025
DipperTheDan
previously approved these changes
Nov 17, 2025
bff170a to
a44712f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed behaviour
Deprecates current version of
RadioButtonandRadioButtonGroup.Adds new version of
RadioButtonandRadioButtonGroupwith audit changes, located in the__next__directory.To achieve this new versions of internal components of
FieldsetandCheckableInputhave also been added.RadioButtonGroup:legendHelpwithlegendHint.sizeprop with values "small", "medium" and "large".RadioButton:labelHelp&fieldHelpwithinputHint.conditionalContentprop.Current behaviour
RadioButtonandRadioButtonGroupare not aligned with the DS.Checklist
d.tsfile added or updated if requiredQA
Additional context
Testing instructions