fix(file-input): add downloaded attribute to completed state link #7651
+53
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DipperTheDan
reviewed
Dec 2, 2025
Contributor
DipperTheDan
left a comment
DipperTheDan
left a comment
There was a problem hiding this comment.
Looks good. Only minor comment is regarding the commit message. Just so it's correct in the release docs when this gets merged.
❌ feat(file-input): add downloated attribute to completed state link
✅ feat(file-input): add downloaded attribute to completed state link
DipperTheDan
approved these changes
Dec 2, 2025
Parsium
approved these changes
Dec 3, 2025
tomdavies73
changed the title
when the upload status of the file input is completed, a link is rendered. This now supports the native download attribute, if the link is suitable for download it will trigger a download event in the browser when pressed. This ensures behaviour is more consistent between the major browsers fix #7633
divyajindel
approved these changes
Dec 4, 2025
Collaborator
|
🎉 This PR is included in version 158.14.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #7633
Proposed behaviour
Adds support for the
downloadattribute onLinkand then adds this attribute once a file upload is completed inFileinputCurrent behaviour
Currently, there is no support for the
downloadattribute onLink, and there is dodownloadattribute once a file upload is completed inFileinputChecklist
d.tsfile added or updated if requiredQA
Additional context
Testing instructions