fix(adaptive-sidebar): ensure rendered sidebar can have accessible name #7652
+102
−8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #7632
Proposed behaviour
adds the
aria-labelandaria-labedlledbyprops to the component, which are applied when the component is rendered as a modal. This ensures consumers have the means to give the component an accessible name when needed.Current behaviour
Currently, there is no mechanism for consumers to set the accessible name on the modal rendered on
AdaptiveSidebar, which is an accessibility issue.Checklist
d.tsfile added or updated if requiredQA
Additional context
Testing instructions