Skip to content

Conversation

@tomdavies73
Copy link
Contributor

Proposed behaviour

Ensures that the commit script can be used cross browser with a temporary file approach for commit message

Current behaviour

Shell escaping has been used heavily for the creation of the commit message, this works fine on some operating systems but is handled differently on Windows OS. This means some users on Windows machines cannot use the script properly to the desired effect.

Checklist

  • Commits follow our style guide
  • Related issues linked in commit messages if required
  • Screenshots are included in the PR if useful
  • All themes are supported if required
  • Unit tests added or updated if required
  • Playwright automation tests added or updated if required
  • Storybook added or updated if required
  • Translations added or updated (including creating or amending translation keys table in storybook) if required
  • Typescript d.ts file added or updated if required
  • Related docs have been updated if required

QA

  • Tested in provided StackBlitz sandbox/Storybook
  • Add new Playwright test coverage if required
  • Carbon implementation matches Design System/designs
  • UI Tests GitHub check reviewed if required

Additional context

Testing instructions

@tomdavies73 tomdavies73 force-pushed the commit_script_improvements branch from addb7d3 to a51f621 Compare December 4, 2025 15:28
@tomdavies73 tomdavies73 changed the title build: ensure commit script can work cross platform chose: ensure commit script can work cross platform Dec 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

1 participant