fix(checkout): Hide cost of shipping in cart when its free shipping #649
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug where shipping costs were being displayed in the cart even when free shipping was available. The fix ensures that when free shipping is active, the shipping cost element is hidden from the cart display.
- Updates the visibility logic for shipping costs to check both real shipping cost and free shipping status
- Hides shipping cost display when free shipping is active
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/assets/js/cart.js | Modified condition to hide shipping cost when free shipping is available |
| public/checkout.js | Compiled/minified JavaScript file reflecting the source changes |
|
|
||
| app.toggleElementClassIf(app.totalDiscount, 'discounted', 'hidden', () => !!cartData.total_discount) | ||
| .toggleElementClassIf(app.shippingCost, 'has_shipping', 'hidden', () => !!cartData.real_shipping_cost) | ||
| .toggleElementClassIf(app.shippingCost, 'has_shipping', 'hidden', () => !!cartData.real_shipping_cost && !cartData.free_shipping_bar?.has_free_shipping) |
There was a problem hiding this comment.
[nitpick] The condition is now complex and could be extracted into a well-named variable for better readability. Consider something like const shouldShowShipping = !!cartData.real_shipping_cost && !cartData.free_shipping_bar?.has_free_shipping;
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
What is the current behaviour? (You can also link to an open issue here)
cost of shipping is showing in cart even the shipping becomes free SP-10922
What is the new behaviour? (You can also link to the ticket here)
hide shipping cost in the cart
Does this PR introduce a breaking change?
Screenshots (If appropriate)