feat: add configurable clock display

[mouadlotfi]

Summary

• add a configurable clock display beside the playback speed control in the modern layout and centered in modern-compact
• show the estimated end time by default, with click-to-toggle current time display
• expose show_clock and clock_font_size in modernz.conf

[Keith94]

The idea has been rejected before: #392.

This clock also breaks the cache info display. Maybe it's better to show it as an optional tooltip instead.

[Samillion]

Hmmm. Is this a desirable feature? I honestly haven't seen it anywhere. Genuinely asking, not rejecting.

For the most part I always found showing remaining time to be an equivalent of this, however, I'd love to know if there is a use case that would benefit from showing the exact time to end instead of a count down. I'm very curious.

[mouadlotfi]

Hmmm. Is this a desirable feature? I honestly haven't seen it anywhere. Genuinely asking, not rejecting.

For the most part I always found showing remaining time to be an equivalent of this, however, I'd love to know if there is a use case that would benefit from showing the exact time to end instead of a count down. I'm very curious.

I've seen this in players like Jellyfin and I find it useful. It complements a countdown rather than replaces it.

[Samillion]

I don't mind it, but the PR needs to be rebased because of conflicts.

Issues:

• Why is it tied to the speed button? You want it to show only if the speed button is showing as well?
• Why was the speed button placement moved?
• show_clock should be disabled by default
• For clock text width, use a wide template, ie: 88:88. Having a bit more is better than less.
• Consider @Keith94 's suggestion to show as a tooltip instead? To avoid layout breakage as described

[Keith94]

From what I saw online, seems like Jellyfin puts the clock element above the seekbar rather than below it. Dunno what implications that might have on osc height and offsets, etc.

Having a tooltip for timecodes sounds reasonable as long as the contents update in real time, but the toggle behavior would need adjusting.

[Samillion]

Having a tooltip for timecodes sounds reasonable as long as the contents update in real time, but the toggle behavior would need adjusting.

It should be a tooltip for time stamps not seekbar, right? 0:00 / 0:00

[Keith94]

Having a tooltip for timecodes sounds reasonable as long as the contents update in real time, but the toggle behavior would need adjusting.

It should be a tooltip for time stamps not seekbar, right? 0:00 / 0:00

Yup, that's what I meant to say. If tooltip was indeed considered as a solution, it could also depend on user_opts.timecurrent state to show different tooltips perhaps (such as current time display / estimated end time mentioned in OP).

[Keith94]

So it could look like this as a tooltip to avoid cluttering up the interface.

[mouadlotfi]

What about this?

[Samillion]

Sure, but you'll have to consider the following:

• In modern layout, if a video is portrait, the time stamps move to where you want the clock to show
• In modern-compact layout, time stamps exist there permanently