-
Notifications
You must be signed in to change notification settings - Fork 0
Test loops #8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test loops #8
Conversation
Samir-Rashid
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work. Thanks for adding all of this. I have some minor comments for you to fix before merging.
Only improvement for future PRs is to pull main before committing or rebasing so there aren't useless merge commits in the history.
Samir-Rashid
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Addressed comments. Looks good now.
Add two tests:
Made changes to
src/instruction.rsandsrc/translate.rsto support additional branch instructions and bit shift left.