DAGE-104: Add info/debug level logging #258
Conversation
nseidan
commented
Nov 5, 2025
nseidan
commented
- added some logs (info/debug level)
nicolo-rinaldi
left a comment
nicolo-rinaldi
left a comment
There was a problem hiding this comment.
Does it make sense to:
- change the message logged in the
dataset_generator/config.py? - log the payloads/url used in the requests?
|
|
||
| # score initial docset | ||
| if config.enable_cartesian_product: | ||
| log.debug("Cartesian product is enabled, so adding cartesian product scores") |
There was a problem hiding this comment.
I would put this inside its function
rre-tools/src/rre_tools/vector_search_doctor/embedding_model_evaluator/main.py
Show resolved
Hide resolved
rre-tools/src/rre_tools/vector_search_doctor/embedding_model_evaluator/main.py
Show resolved
Hide resolved
what messages you want to change?
I think we should not log the entire payload, because it might be lengthy, if we log at the debug level, we shoudl truncate it. |
|
I would change this into something that says that the config file is the one related to the dataset generator, as we did for the other 2 modules. For logging the payload, I agree to log it in debug mode (even before, but I didn't specify it). I just think it is very useful when debugging the code to have the payload/url printed, so I can see what the code is actually doing. |
|
partial payload is (first 500chars) logged at the debug level |
