-
Notifications
You must be signed in to change notification settings - Fork 145
update workarenax.csv #383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update workarenax.csv #383
Conversation
| workarenax.erpnext.create_payment_entry_without_cost_center.154,workarenax,erpnext,create-payment-entry-without-cost-center,test | ||
| workarenax.erpnext.create_payment_entry_without_cost_center.155,workarenax,erpnext,create-payment-entry-without-cost-center,test | ||
| workarenax.erpnext.create_payment_entry_with_cost_center_cheque_date_reference.156,workarenax,erpnext,create-payment-entry-with-cost-center-cheque-date-reference,test | ||
| workarenax.erpnext.create_payment_entry_with_cost_center_cheque_date_reference.157,workarenax,erpnext,create-payment-entry-with-cost-center-cheque-date-reference,test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would have thought you just appended new tasks to the end, but I see ids have changed: create-payment-entry-with-cost-center-cheque-date-reference used to be 156 and 157 but now they are 142 and 143. How come?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah i was grouping similar tasks together (so all the create_user tasks follow one another, etc.) but i can modify to just append if we need to maintain the same ids from previous runs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that would be better, so every time we add new tasks, we are just adding. Otherwise, it may seem as we are replacing tasks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
makes sense, i'll update the other PR with the jsonl so it also appends
marquezo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
3639cb6
into
scratch/workarenax_benchmarks
updated with Jordan's hard tasks