Skip to content

[Bulk Ops CLI] remove extra newline from bulk mutation variables #6788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jordanverasamy wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −3
Open

[Bulk Ops CLI] remove extra newline from bulk mutation variables #6788

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions packages/app/src/cli/services/bulk-operations/stage-file.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ describe('stageFile', () => {
const uploadedBlob = fileAppendCall?.[1] as Blob
const uploadedContent = await uploadedBlob?.text()

expect(uploadedContent).toBe('{"input":{"id":"gid://shopify/Product/123","tags":["test"]}}\n')
expect(uploadedContent).toBe('{"input":{"id":"gid://shopify/Product/123","tags":["test"]}}')
})

test('handles JSONL with multiple lines correctly', async () => {
Expand All @@ -94,7 +94,6 @@ describe('stageFile', () => {
'{"input":{"id":"gid://shopify/Product/1","title":"New Shirt"}}',
'{"input":{"id":"gid://shopify/Product/2","title":"Cool Pants"}}',
'{"input":{"id":"gid://shopify/Product/3","title":"Nice Hat"}}',
'',
Copy link
Contributor Author

@jordanverasamy jordanverasamy Jan 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This empty string right here should've been a smoking gun indicating a bug before, but we all missed it in review!)

].join('\n')

expect(uploadedContent).toBe(expectedContent)
Expand Down
2 changes: 1 addition & 1 deletion packages/app/src/cli/services/bulk-operations/stage-file.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ interface StageFileOptions {
export async function stageFile(options: StageFileOptions): Promise<string> {
const {adminSession, variablesJsonl} = options

const buffer = Buffer.from(variablesJsonl ? `${variablesJsonl}\n` : '', 'utf-8')
const buffer = Buffer.from(variablesJsonl ?? '', 'utf-8')
Copy link
Contributor

@ericlee878 ericlee878 Jan 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did we add an extra ? here?

Copy link
Contributor Author

@jordanverasamy jordanverasamy Jan 22, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good question!! That is the nullish coalescing operator.

Basically, I first removed the \n, and I got this:

variablesJsonl ? variablesJsonl : ''

This is a common pattern, and is of course equivalent to:

variablesJsonl || ''

?? is an operator that works like ||, except that if the left value is defined-but-falsy (like e.g. ''), || will fall back to the right value, whereas ?? will respect that defined value.

In this case the only falsy value you'll reasonably get here is '', in which case whether we use that or the fallback we'll get an empty string either way. So, ?? and || are going to behave equivalently in all cases here.

I lean towards ?? by default because I don't want to think about JS's weird falsy values unless I have to, so I ended up with:

variablesJsonl ?? ''

const filename = 'bulk-variables.jsonl'
const size = buffer.length

Expand Down
Loading