Skip to content

Implement get_app_token and other fixes#25

Open
nab138 wants to merge 30 commits intoSideStore:masterfrom
nab138:master
Open

Implement get_app_token and other fixes#25
nab138 wants to merge 30 commits intoSideStore:masterfrom
nab138:master

Conversation

@nab138
Copy link

@nab138 nab138 commented Aug 8, 2025

Changes in icloud_auth

  • Updated dependencies
  • Completed implementation of get_app_token
  • Added send_request method to send and receive plist data in authenticated request with the proper headers
  • Allows appleid or 2fa closure to fail gracefully (e.g. user cancels login)

Changes in omnisette

  • Updated dependencies

@polymo1
Copy link
Member

polymo1 commented Aug 9, 2025

Given the size of this PR, I feel it needs a description. Could you provide that?

@polymo1 polymo1 added the question Further information is requested label Aug 9, 2025
@polymo1
Copy link
Member

polymo1 commented Aug 9, 2025

Additionally, one of the dependencies you've added fails to build in CI.

@polymo1 polymo1 added the help wanted Extra attention is needed label Aug 9, 2025
@nab138
Copy link
Author

nab138 commented Aug 9, 2025

I wrote up a quick description, I worked on the sporadically several months ago so it's possible I missed something but I tried to be thorough. As for the dependency, I could enable the vendored feature by default, enable the vendored feature in ci specifically, or install botan in the action before attempting to build. I'm fairly new to this kind of stuff so I'm not sure what the "standard" thing to do here would be.

@nab138
Copy link
Author

nab138 commented Aug 9, 2025

Honestly most of the changes came from my formatter, the pr is a lot smaller than it seems

@nab138
Copy link
Author

nab138 commented Nov 9, 2025

I've removed the dependency on botan so CI should work. Some other dependencies have also been updated.

@SternXD SternXD requested a review from a team November 10, 2025 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

help wanted Extra attention is needed question Further information is requested

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants