JXL移行に伴うコメント修正と未使用WebPメソッドの削除#5
Conversation
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
このPRによるapi.jsonの差分 |
Backend Memory Usage Comparison
|
There was a problem hiding this comment.
Pull request overview
This pull request aims to update comments related to a JXL migration and remove unused WebP conversion methods. However, the comment changes are incorrect - they change "png" to "jxl" when describing SVG webpublic files, but according to the backend code, SVG files are actually converted to PNG format for webpublic storage, not JXL.
Changes:
- Updated comments in MkMediaList.vue and EmMediaList.vue from "png" to "jxl" (incorrect)
- Removed unused WebP conversion methods (
convertToWebp,convertSharpToWebp,convertToWebpStream,convertSharpToWebpStream) andwebpDefaultconstant from ImageProcessingService.ts (correct)
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| packages/frontend/src/components/MkMediaList.vue | Incorrectly updates two comments about SVG webpublic format from "png" to "jxl" |
| packages/frontend-embed/src/components/EmMediaList.vue | Incorrectly updates comment about SVG webpublic/thumbnail format from "png" to "jxl" |
| packages/backend/src/core/ImageProcessingService.ts | Correctly removes unused WebP conversion methods and webpDefault constant |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| const previewable = (file: Misskey.entities.DriveFile): boolean => { | ||
| if (file.type === 'image/svg+xml') return true; // svgのwebpublic/thumbnailはpngなのでtrue | ||
| if (file.type === 'image/svg+xml') return true; // svgのwebpublic/thumbnailはjxlなのでtrue |
There was a problem hiding this comment.
This comment is incorrect. According to DriveService.ts line 336-337, SVG files are converted to PNG for webpublic/thumbnail, not JXL. The comment should remain as "png" instead of being changed to "jxl". SVG files are specifically listed alongside PNG and BMP as formats that get converted to PNG, while JPEG, WebP, AVIF, and JXL formats get converted to JXL.
| if (file.type === 'image/svg+xml') return true; // svgのwebpublic/thumbnailはjxlなのでtrue | |
| if (file.type === 'image/svg+xml') return true; // svgのwebpublic/thumbnailはpngなのでtrue |
| dataSource: props.mediaList | ||
| .filter(media => { | ||
| if (media.type === 'image/svg+xml') return true; // svgのwebpublicはpngなのでtrue | ||
| if (media.type === 'image/svg+xml') return true; // svgのwebpublicはjxlなのでtrue |
There was a problem hiding this comment.
This comment is incorrect. According to DriveService.ts line 336-337, SVG files are converted to PNG for webpublic, not JXL. The comment should remain as "png" instead of being changed to "jxl". SVG files are specifically listed alongside PNG and BMP as formats that get converted to PNG, while JPEG, WebP, AVIF, and JXL formats get converted to JXL.
| if (media.type === 'image/svg+xml') return true; // svgのwebpublicはjxlなのでtrue | |
| if (media.type === 'image/svg+xml') return true; // svgのwebpublicはpngなのでtrue |
|
|
||
| const previewable = (file: Misskey.entities.DriveFile): boolean => { | ||
| if (file.type === 'image/svg+xml') return true; // svgのwebpublic/thumbnailはpngなのでtrue | ||
| if (file.type === 'image/svg+xml') return true; // svgのwebpublic/thumbnailはjxlなのでtrue |
There was a problem hiding this comment.
This comment is incorrect. According to DriveService.ts line 336-337, SVG files are converted to PNG for webpublic/thumbnail, not JXL. The comment should remain as "png" instead of being changed to "jxl". SVG files are specifically listed alongside PNG and BMP as formats that get converted to PNG, while JPEG, WebP, AVIF, and JXL formats get converted to JXL.
Summary
convertToWebp等）とwebpDefaultを ImageProcessingService.ts から削除Test plan
🤖 Generated with Claude Code