build first class callables for hooks#9206
Open
live627 wants to merge 5 commits intoSimpleMachines:release-3.0from
Open
build first class callables for hooks#9206live627 wants to merge 5 commits intoSimpleMachines:release-3.0from
live627 wants to merge 5 commits intoSimpleMachines:release-3.0from
Conversation
live627
commented
May 5, 2026
Co-authored-by: John Rayes <live627@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the first of a series of pull requests that will convert string callables to first-class callables. Each branch will focus on a single related unit. For example, this one addresses hooks, while another one focuses on menus, and so on.
Fully backward compatible. I have compiled a script testing all the various callable types that I can think of:
https://github.com/live627/benchmark-tests/blob/main/callables.php
It’s quite interesting how the static
class::methodsyntax lost the horse race. Any string method will be slower because it is internally converted to a callable, and the first-class syntax can be used directly:https://github.com/live627/benchmark-tests/blob/main/callables.txt