Skip to content

Accessibility critical issues are fixed. #406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sc-ArshadHannan merged 1 commit into from
Dec 17, 2025
Merged

Accessibility critical issues are fixed. #406

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/components/demo-tab.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ export default function DemoTab({ id, code, component, defaultTab = "preview" }:
<TabsList className="w-full rounded-none justify-start">
<TabsTrigger value="preview">Preview</TabsTrigger>
<TabsTrigger value="code">Code</TabsTrigger>
<TabsTrigger value="" className="w-full pointer-events-none"></TabsTrigger>
<TabsTrigger value="" className="w-full pointer-events-none" aria-hidden="true" tabIndex={-1}></TabsTrigger>

</TabsList>
<TabsContent value="preview" className="min-h-[200px] p-8 bg-subtle-bg flex items-center justify-center rounded-b-md">
Expand Down
5 changes: 3 additions & 2 deletions src/components/layout/topbar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -372,7 +372,7 @@ export default function TopBar() {
<div className="lg:hidden">
<DropdownMenu>
<DropdownMenuTrigger asChild>
<Button variant="ghost" size="icon">
<Button variant="ghost" size="icon" aria-label="Open navigation menu">
<Icon path={mdiMenu} size={1} />
</Button>
</DropdownMenuTrigger>
Expand Down Expand Up @@ -546,12 +546,13 @@ export default function TopBar() {
href={externalLinks?.Block_github || ""}
target="_blank"
rel="noopener noreferrer"
aria-label="View GitHub repository"
>
<Icon path={mdiGithub} size={1} />
</a>
</Button>

<Button variant="ghost" size="icon" onClick={toggleDarkMode} className="hover:bg-muted active:bg-muted">
<Button variant="ghost" size="icon" onClick={toggleDarkMode} className="hover:bg-muted active:bg-muted" aria-label={isDark ? "Switch to light mode" : "Switch to dark mode"}>
<Icon path={mdiCircleHalfFull} size={1} />
</Button>
</div>
Expand Down