Update dependencies and cleanup #392
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JimBobSquarePants
added
breaking
dependencies
4 tasks
There was a problem hiding this comment.
Pull Request Overview
Updates AWS SDK S3 and Azure Storage Blobs dependencies to newer versions while performing code cleanup and improvements. The changes address compatibility requirements and enhance code quality.
- Updates
AWSSDK.S3to version4.0.6.2andAzure.Storage.Blobsto version12.25.0 - Adds compatibility fixes for the updated AWS SDK including new parameters and null handling
- Improves code quality with spelling corrections, modern C# syntax, and better documentation
Reviewed Changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| src/ImageSharp.Web.Providers.AWS/ImageSharp.Web.Providers.AWS.csproj | Updates AWSSDK.S3 package to version 4.0.6.2 |
| src/ImageSharp.Web.Providers.Azure/ImageSharp.Web.Providers.Azure.csproj | Updates Azure.Storage.Blobs package to version 12.25.0 |
| tests/ImageSharp.Web.Tests/TestUtilities/AWSS3StorageImageProviderFactory.cs | Adds compatibility fixes for AWS SDK update including new parameters |
| src/ImageSharp.Web.Providers.AWS/Resolvers/AWSS3StorageImageResolver.cs | Fixes null handling for LastModified property |
| src/ImageSharp.Web.Providers.AWS/Caching/AWSS3StorageCache.cs | Adds UseChunkEncoding parameter and fixes spelling errors |
| src/ImageSharp.Web/Middleware/ImageContext.cs | Adds readonly modifiers to methods and fixes spelling |
| src/ImageSharp.Web/Middleware/ResponseConstants.cs | Corrects spelling error in comment |
| src/ImageSharp.Web/Providers/PhysicalFileSystemProvider.cs | Adds XML documentation for exception |
| tests/ImageSharp.Web.Tests/TestUtilities/ServerTestBase.cs | Comments out environment variable logging |
| README.md | Updates Azurite command with skipApiVersionCheck flag |
| .github/workflows/build-and-test.yml | Updates CI configuration with skipApiVersionCheck flag |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
AWSSDK.S3to4.0.6.2Fixes MissingMethodException thrown targeting latest version of AWSSDK.S3 library (v4.0.1.3) #386Azure.Storage.Blobsto12.25.0