Skip to content

Conversation

@priyanshujain
Copy link

@priyanshujain priyanshujain commented Nov 11, 2025

Description

When alter table adds/drops columns on a parent Iceberg table, automatically apply the same schema changes to child Iceberg tables. This ensures field_id mappings are synced across the inheritance hierarchy.

Fixes #6 "missing field for column" errors when querying child tables after parent schema modifications.

Reference Screenshot

image

Checklist

  • I have tested my changes and added tests if necessary
  • I updated documentation if needed
  • I confirm that all my commits are signed off (DCO)

@sfc-gh-mslot
Copy link
Collaborator

sfc-gh-mslot commented Nov 11, 2025

Nice. Thanks for doing this. Would it be possible to add some tests?

@priyanshujain
Copy link
Author

priyanshujain commented Nov 12, 2025

@sfc-gh-mslot I’ve added a schema propagation test with three cases - adding a column, renaming a column, and dropping the column.
image

@sfc-gh-okalaci
Copy link
Collaborator

Thanks @priyanshujain for the contribution.

We added DCO (https://developercertificate.org/) to our repo. The new PRs will inform you via the PR templates, but your PR pre-dates that.

Do you mind following the DCO part from this: https://github.com/Snowflake-Labs/pg_lake/blob/main/.github/pull_request_template.md

Thanks!

@priyanshujain priyanshujain force-pushed the 6-inheritance-schema-propagation branch from e779251 to 07e2766 Compare November 18, 2025 05:50
@priyanshujain
Copy link
Author

priyanshujain commented Nov 18, 2025

Do you mind following the DCO part?

@sfc-gh-okalaci I have completed it.

@priyanshujain
Copy link
Author

@sfc-gh-mslot / @sfc-gh-okalaci Could you please review this?

@priyanshujain
Copy link
Author

@sfc-gh-mslot I fixed the CI failure issues that occurred due to code formatting.

@priyanshujain priyanshujain force-pushed the 6-inheritance-schema-propagation branch from b328be6 to 7e3d413 Compare November 24, 2025 07:09
Copy link
Collaborator

@sfc-gh-mslot sfc-gh-mslot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice contribution, thanks! Will be merged via #76

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Schema changes should propagate to inheritance children

3 participants