-
Notifications
You must be signed in to change notification settings - Fork 54
Propagate schema changes to child Iceberg tables in inheritance hierarchies #48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Propagate schema changes to child Iceberg tables in inheritance hierarchies #48
Conversation
|
Nice. Thanks for doing this. Would it be possible to add some tests? |
|
@sfc-gh-mslot I’ve added a schema propagation test with three cases - adding a column, renaming a column, and dropping the column. |
|
Thanks @priyanshujain for the contribution. We added DCO (https://developercertificate.org/) to our repo. The new PRs will inform you via the PR templates, but your PR pre-dates that. Do you mind following the DCO part from this: https://github.com/Snowflake-Labs/pg_lake/blob/main/.github/pull_request_template.md Thanks! |
…rchies Signed-off-by: PJ <[email protected]>
Signed-off-by: PJ <[email protected]>
e779251 to
07e2766
Compare
@sfc-gh-okalaci I have completed it. |
|
@sfc-gh-mslot / @sfc-gh-okalaci Could you please review this? |
|
@sfc-gh-mslot I fixed the CI failure issues that occurred due to code formatting. |
Signed-off-by: PJ <[email protected]>
b328be6 to
7e3d413
Compare
sfc-gh-mslot
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice contribution, thanks! Will be merged via #76

Description
When alter table adds/drops columns on a parent Iceberg table, automatically apply the same schema changes to child Iceberg tables. This ensures field_id mappings are synced across the inheritance hierarchy.
Fixes #6 "missing field for column" errors when querying child tables after parent schema modifications.
Reference Screenshot
Checklist