Filament Ironing Override #11194
Open
Filament Ironing Override #11194
+200
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
ianalexis
force-pushed
the
filament-ironing
branch
from
2ce890e to
c4b481e
Compare
Noisyfox
reviewed
Oct 31, 2025
src/slic3r/GUI/Tab.cpp
Outdated
| #include "SavePresetDialog.hpp" | ||
| #include "EditGCodeDialog.hpp" | ||
|
|
||
| #include <memory> |
Collaborator
There was a problem hiding this comment.
What is this header used for?
Contributor
Author
There was a problem hiding this comment.
Removed, It was when I was trying to fix the checkboxes. I'm not proud of the solution using unique_ptr, but I couldn't replicate the use of retraction overrides, and it was the only way I could get them to work.
Maybe I can add a //TODO comment in the code saying that this is a section to review later.
ianalexis
force-pushed
the
filament-ironing
branch
3 times, most recently
from
20ea42c to
0326cf7
Compare
ianalexis
force-pushed
the
filament-ironing
branch
from
0326cf7 to
ad24289
Compare
ianalexis
force-pushed
the
filament-ironing
branch
from
ad24289 to
fa5fa63
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #10508
Allow different types of flow, spacing, inset, and speed to be configured for ironing values