Skip to content

Conversation

@avaruus1
Copy link
Contributor

@avaruus1 avaruus1 commented Jan 15, 2026

SpongeAPI | Sponge

Implements Adventure's ClickEvent.callback & moves Sponge's existing callback implementation to use the new system.

@Yeregorix
Copy link
Member

Yeregorix commented Jan 22, 2026

I agree with this change but please note that it may not stay very long in place as I plan to replace all our adventure implementation with the official adventure-platform-mod as soon as I have time to work on it.

@aromaa
Copy link
Member

aromaa commented Jan 22, 2026

Just gonna mention it here too that this will not satisfy our contracts. The permission checks are done against the Audience instead of the underlying Subject. These objects are not equal and each can hold distinct set of permissions. I'm worried that this will be surprising behavior as it will go against the default contract we have for commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants