Validate contract list sort fields#62
Closed
pranavpandey2511 wants to merge 1 commit into
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User description
Summary
get_contract_listbuilt-in sort-field whitelist in the MCP schema and runtime validation.contract_idas filter-only so invalidsortFilters: contract_idfails locally instead of reaching the public API assort=filter__contract_id.contract_idsorting, and mixed built-in/metadata sort serialization.Root Cause
The MCP tool accepted free-form
sortFilters, so the model could requestcontract_id. The server converted that intofilter__contract_id, which passes the public API parameter shape but is not a valid Elasticsearch sort field forContractSearchObjectV2Elastic.Validation
npm testpassed: 20 testsgit diff --checkpassedGenerated description
Below is a concise technical summary of the changes proposed in this PR:
Enforce whitelist validation for
get_contract_listbuilt-in sort fields by extending its schema and runtime logic withValidationErrorchecks before translating requests to SpotDraft. Documentcontract_idas a filter-only field in the tool guidance so agents avoid unsupported sort params that previously reached the public API.contract_idsorting and mixed built-in/metadata sorts.Modified files (1)
Latest Contributors(1)
get_contract_listschema patterns and runtime checks so only supported fields reach the SpotDraft API andcontract_idremains filter-only.Modified files (2)
Latest Contributors(2)