feat(empty-state): new SHINE styles and Svelte Component #2100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 306a2f3 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for stacks-svelte ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for stacks ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This reverts commit c24783d.
mukunku
commented
Dec 16, 2025
mukunku
requested review from
CGuindon,
dancormier,
giamir and
ttaylor-stack
CGuindon
approved these changes
Dec 16, 2025
dancormier
requested changes
Dec 18, 2025
Contributor
dancormier
left a comment
dancormier
left a comment
There was a problem hiding this comment.
Thanks for building this out @mukunku. I have a few suggestions to tidy things up and reinforce a bit more consistency across the component/library. Nothing too out there. Let me know if anything could use clarification
packages/stacks-classic/lib/components/empty-state/empty-state.less
Outdated
Show resolved
Hide resolved
packages/stacks-svelte/src/components/EmptyState/EmptyState.stories.svelte
Outdated
Show resolved
Hide resolved
packages/stacks-svelte/src/components/EmptyState/EmptyState.svelte
Outdated
Show resolved
Hide resolved
packages/stacks-classic/lib/components/empty-state/empty-state.less
Outdated
Show resolved
Hide resolved
packages/stacks-svelte/src/components/ExpandingInput/ExpandingInput.svelte
Outdated
Show resolved
Hide resolved
dancormier
reviewed
Dec 18, 2025
packages/stacks-svelte/src/components/EmptyState/EmptyState.svelte
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR:
EmptyStateSvelte componentExpandingInputto Svelte 5 syntax.How to Test
EmptyStateSvelte component: https://deploy-preview-2100--stacks-svelte.netlify.app/?path=/docs/components-emptystate--docsExpandingInputworks again: https://deploy-preview-2100--stacks-svelte.netlify.app/?path=/docs/components-expandinginput--docs