Add action to get/create/delete zone access rule #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@StackStorm-Exchange/encoretechnologies Can you folks please help reviewing the contribution? |
bishopbm1
requested changes
Mar 23, 2022
bishopbm1
left a comment
bishopbm1
left a comment
There was a problem hiding this comment.
Thank you for the PR! Just needs some unit tests and please add to the ChangeLog and bump the version in the pack.yaml file.
| # invoke the Cloudflare APIo | ||
| raw_results = func(*args, params=copy.deepcopy(params)) | ||
| # invoke the Cloudflare API | ||
| if func.__name__ == 'post': |
There was a problem hiding this comment.
Would like to see 2 tests to show the different conditions are being executed as expected. https://github.com/StackStorm-Exchange/stackstorm-cloudflare/blob/master/tests/test_action_base.py
Author
There was a problem hiding this comment.
Sorry for the delay, I was on vacation. I'll look at this soon.
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add 3 new action:
create_zone_access_rule- create a firewall access rule for a zonedelete_zone_access_rule- delete a firewall access rule from a zoneget_zone_access_rule- list/search firewall access rule in a zoneAlso, it adjusts
lib/actions.pyto allow do POST requests.