Open
Conversation
…enhance resource management
nscheibe
approved these changes
Mar 4, 2025
Member
nscheibe
left a comment
nscheibe
left a comment
There was a problem hiding this comment.
Well done. Just some little comments.
| </PropertyGroup> | ||
|
|
||
| <ItemGroup> | ||
| <PackageReference Include="Azure.Messaging.ServiceBus" Version="7.18.0" /> |
Member
There was a problem hiding this comment.
Do we have no central package management?
|
|
||
| public record UserConfig( | ||
| Namespace[] Namespaces, | ||
| Logging Logging); |
Member
There was a problem hiding this comment.
I would prefer a line break between the records.
|
|
||
| return new Status { IsReady = true }; | ||
| } | ||
| catch (Exception ex) |
Member
There was a problem hiding this comment.
I would somehow not swallow the exception, is there a possibility to add it to the Status, or so, at least the message?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Work in progress...
ComposeResourceto a defaultcomposenetworkStuffs not supported and kind of needed: