feat(registry): optimize default nickname logic for user participants#473
Open
bytedaring wants to merge 2 commits into
Open
feat(registry): optimize default nickname logic for user participants#473bytedaring wants to merge 2 commits into
bytedaring wants to merge 2 commits into
Conversation
Updated the fallback key for user participant default names `from common.you` to `profile.defaultNickname`. This ensures consistency with the default values used on the profile page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated the fallback key for user participant default names from
common.youtoprofile.defaultNickname. This ensures consistency with the default values used on the profile page.Summary
This PR refactors the default nickname acquisition logic for user participants. By switching the fallback key from
common.youtoprofile.defaultNickname, we ensure that the user's display name remains consistent across the Registry and the Profile modules.Related Issues
N/A
Changes
common.youtoprofile.defaultNickname.Type of Change
Verification
Steps to reproduce / test
profile.defaultNickname(instead ofcommon.you).What you personally verified
Evidence
pnpm check && pnpm lint && npx tsc --noEmit)Checklist