fix(code): Stagger initial typing animation#549
Open
ALikesToCode wants to merge 1 commit intoTHU-MAIC:mainfrom
Open
fix(code): Stagger initial typing animation#549ALikesToCode wants to merge 1 commit intoTHU-MAIC:mainfrom
ALikesToCode wants to merge 1 commit intoTHU-MAIC:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix the code element entrance animation so multi-line code starts with animation state available on the first render instead of applying it asynchronously after rows have already mounted. This preserves the intended line-by-line typewriter reveal.
Related Issues
Fixes #531
Changes
CodeLineRowmounts.setTimeout(..., 0)animation-state handoff that let all rows enter the typing path together.Type of Change
Verification
Steps to reproduce / test
CodeLineRowmounts.Local checks
pnpm exec vitest run tests/code-element/line-animation.test.ts- passed, 1 test file and 4 tests.pnpm check- passed.pnpm lint- passed with existing warnings outside this PR.pnpm exec tsc --noEmit- passed.pnpm check:i18n-keys- passed.pnpm test- passed, 43 test files and 317 tests.git diff --check- passed.Build and runtime checks
pnpm build- passed.pnpm dev- started successfully onhttp://localhost:3001after port 3000 was already in use.curl -I http://localhost:3001- returned HTTP 200.curl http://localhost:3001/api/health- returnedsuccess: true,status: ok, version0.2.1./- HTTP 200, titleOpenMAIC, 0 captured page/console errors./eval/whiteboard- HTTP 200, titleOpenMAIC, 0 captured page/console errors.Regression coverage
CI evidence
Checklist