fix: prevent memory leaks and silent export failures#552
Open
arnow117 wants to merge 5 commits into
Open
Conversation
- use-browser-asr: add cleanup on unmount to abort active SpeechRecognition and release microphone - use-streaming-text: use ref for onComplete callback to prevent animation restarts when parent re-renders - use-export-pptx: check resp.ok before consuming fetch bodies to avoid silent failures with corrupted images in exported slides
The else block was missing its closing brace, causing Turbopack parse errors in CI (4 "Expected a semicolon" errors).
Log statements exceeded printWidth limit — Prettier auto-wrapped.
…SLint rule ESLint error: "Cannot access refs during render" — moved `onCompleteRef.current = onComplete` into its own useEffect. Also removed now-unnecessary eslint-disable comment.
Removing the directive exposed a pre-existing lint error on line 72. The actual fix (ref assignment in useEffect) is preserved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
onCompletecallback withuseRefto prevent animation restarts when parent re-renders. Previously, any re-render that created a newonCompletefunction reference would restart the entire streaming animation.resp.okchecks at 3fetch()calls to avoid silently embedding corrupted images/media when HTTP requests fail (e.g., 403, 404, 500). Failed resources are now skipped with a warning log.Test plan
useBrowserASRwhile recording