Add retries to the Remote Reward Model, do not fail on connection drops or endpoint instability#1582
Open
joyliu-q wants to merge 4 commits intoTHUDM:mainfrom
Open
Add retries to the Remote Reward Model, do not fail on connection drops or endpoint instability#1582joyliu-q wants to merge 4 commits intoTHUDM:mainfrom
joyliu-q wants to merge 4 commits intoTHUDM:mainfrom
Conversation
…connection drops or endpoint shakiness
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
During eval rollouts, thousands of reward model requests fire simultaneously, overwhelming the remote endpoint.
Without having a very resilient endpoint, this causes:
Solution
Added robustness improvements to
remote_rm:Connection pooling & concurrency limiting
aiohttp.ClientSessioninstead of creating one per requestSmart retry logic
Cleanup
Testing
Ran training with a flaky endpoint - retries handled connection drops gracefully
Verified 4xx errors fail fast without wasting retry budget