Fix for Shift out of range#20
Draft
Lawrence Lucas Large (LukeLarge) wants to merge 1 commit into
Draft
Conversation
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com> Signed-off-by: Lawrence Lucas Large <162439255+LukeLarge@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Fixes a JavaScript/TypeScript << shift overflow by replacing an out-of-range bit shift expression with a correct 32-bit max constant, preserving the intended random opcode range.
Changes:
- Replaced
(1 << 32) - 1with0xFFFFFFFFto represent the 32-bit unsigned maximum safely in JS/TS number semantics.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| do { | ||
| testOp = getRandomInt(1, (1 << 32) - 1); | ||
| testOp = getRandomInt(1, 0xFFFFFFFF); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
General fix: replace out-of-range bit shift expressions with arithmetic or constants that correctly represent 32-bit bounds in JS/TS number semantics.
Best fix here: in
tests/WalletW5.spec.tsat line 786, replace(1 << 32) - 1with0xFFFFFFFF(equivalently2 ** 32 - 1). This preserves intended functionality (random opcode from1..4294967295) without changing behavior elsewhere and avoids introducing new imports/dependencies.Suggested fixes powered by Copilot Autofix. Review carefully before merging.