Happy Thoughts by Cathi

[violacathrine]

https://happythoughtsbyc.netlify.app/

[HolaCarmensita]

Så fin app, du ska vars så nöjd och jag vet hur du kämpade, grymt!

Food for thought

API-logik som custom hook?
Det går att flytta fetch/POST-logiken från thoughts.js till en custom hook (t.ex. useThoughts) som kan hantera logiken som GET, POST, returnera thoughts, isLoading, error etc.

React documenation

Mastering Custom Hooks in React

Like-knappen som en mer ansvarstagande komponent?
Du skulle kunna låta LikeButton ta emot thoughtId, isLiked och hearts som props, och låta den sköta sitt eget state samt POST-anrop för lokala uppdateringar.

Global styling med Styled Components?
Ett alternativ är att samla färger, typsnitt och breakpoints i en GlobalStyles eller theme.js för att undvika duplicerad styling i varje komponent, det upplever jag också blir enklare i längden i stylingarbetet

140 character input error handling
When writing a to long message, you rechive a "-10 characters remaining" instead of something like "10 characters to long". A alternativ could be to just not show that line at all after using more than 140 character (display none), and only show the error message just under it saying "Your message is too long".

[HIPPIEKICK]

Please update your app with this new link (you can use cmd+shift+F to search for all the instances in a repo).

https://happy-thoughts-api-4ful.onrender.com/

In the meantime, nice to see you’re continuing with styled components 🤩

[violacathrine]

Please update your app with this new link (you can use cmd+shift+F to search for all the instances in a repo).

https://happy-thoughts-api-4ful.onrender.com/

In the meantime, nice to see you’re continuing with styled components 🤩

Is this new link supposed to be connected to the project in Backend sprint? I think i’m confused if i did it right - since i got alot of console warnings in inspect using the new link.

[HIPPIEKICK]

Is this new link supposed to be connected to the project in Backend sprint? I think i’m confused if i did it right - since i got alot of console warnings in inspect using the new link.

You will build your own Happy Thoughts API during the backend sprint, yes. But right now, the only thing you need to do for this React project is to switch out the old API link in all places to the new one.

[violacathrine]

Thanks! Had a hell trying to understand what was wrong, but needed to do a little change with the url and also environment variable at Netlify! Should be working tree clean now. xD

…

________________________________ Från: Matilda Brunemalm ***@***.***> Skickat: den 28 maj 2025 10:09 Till: Technigo/js-project-happy-thoughts ***@***.***> Kopia: Cathrine ***@***.***>; Author ***@***.***> Ämne: Re: [Technigo/js-project-happy-thoughts] Happy Thoughts by Cathi (PR #20) [https://avatars.githubusercontent.com/u/51529201?s=20&v=4]HIPPIEKICK left a comment (Technigo/js-project-happy-thoughts#20)<#20 (comment)> Is this new link supposed to be connected to the project in Backend sprint? I think i’m confused if i did it right - since i got alot of console warnings in inspect using the new link. You will build your own Happy Thoughts API during the backend sprint, yes. But right now, the only thing you need to do for this React project is to switch out the old API link in all places to the new one. — Reply to this email directly, view it on GitHub<#20 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AKN23GQWYL5KXVIZ63PR4OD3AVVKLAVCNFSM6AAAAAB44LFFW6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDSMJVGM4DAMRSGQ>. You are receiving this because you authored the thread.Message ID: ***@***.***>

[HIPPIEKICK]

Apart from that you've only got 90 in Lighthouse score, you're good to go. Rise and I'll approve 🪄

[violacathrine]

Hi again, I will absolutley do that. But even more confused now, because thats not what you wrote in the Requirements for the Happy Thoughts project? [cid:7e6d475d-0282-4a53-8953-431bbb2111a9]

…

________________________________ Från: Matilda Brunemalm ***@***.***> Skickat: den 28 maj 2025 10:58 Till: Technigo/js-project-happy-thoughts ***@***.***> Kopia: Cathrine ***@***.***>; Author ***@***.***> Ämne: Re: [Technigo/js-project-happy-thoughts] Happy Thoughts by Cathi (PR #20) @HIPPIEKICK requested changes on this pull request. Apart from that you've only got 90 in Lighthouse score, you're good to go. Rise and I'll approve 🪄 — Reply to this email directly, view it on GitHub<#20 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AKN23GVIIVWRTCCEJULEJN33AV3BZAVCNFSM6AAAAAB44LFFW6VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDQNZUGE4TAMRVGA>. You are receiving this because you authored the thread.Message ID: ***@***.***>

[HIPPIEKICK]

Oh my, I'm so sorry Cathi - I was certain we had that as a requirement 🙈 Well, no harm in improving a11y I guess but sorry for "forcing" you 😅