Skip to content

Conversation

@RPaemurd
Copy link

Here is my Portfolio assigmnet!
https://portfolio-technigo.netlify.app/

text-align: center;
width: 100%; /* Mobil (standard): Staplad layout */

@media (min-width: 900px) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have the same media query 3 times in this styled.div. Try to place the media query at the bottom of the styling section and have only one :)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woops! :D I put together two of them but I have to keep the ul::after media query since its inside the ul :)

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No worries!
You can put the media query around the ul as well. Just write it again :)

 ul::after {
    ...
}

@media (min-width: 900px) {
    ...
    
    ul::after {
        ...
    }
}

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great point :) I think I fixed it now :)

Copy link

@Npahlfer Npahlfer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would have been nice to see the use of a theme file for colors, media queries and such. The padding in mobile is a bit on the large side, but overall good job! :)

@RPaemurd
Copy link
Author

RPaemurd commented Dec 5, 2025

Great idea! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants