-
Notifications
You must be signed in to change notification settings - Fork 55
Hand in Portfolio Technigo #42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…nent responsiveness
src/sections/Skills.jsx
Outdated
| text-align: center; | ||
| width: 100%; /* Mobil (standard): Staplad layout */ | ||
|
|
||
| @media (min-width: 900px) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have the same media query 3 times in this styled.div. Try to place the media query at the bottom of the styling section and have only one :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Woops! :D I put together two of them but I have to keep the ul::after media query since its inside the ul :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No worries!
You can put the media query around the ul as well. Just write it again :)
ul::after {
...
}
@media (min-width: 900px) {
...
ul::after {
...
}
}There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great point :) I think I fixed it now :)
Npahlfer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would have been nice to see the use of a theme file for colors, media queries and such. The padding in mobile is a bit on the large side, but overall good job! :)
|
Great idea! :) |
Here is my Portfolio assigmnet!
https://portfolio-technigo.netlify.app/