-
Notifications
You must be signed in to change notification settings - Fork 55
Daniel Lauding + Portfolio #51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Npahlfer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅
carro-barro
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wow riktigt bra jobbat!!
var lite svårt att ge konstruktiv feedback då mycket var lite överkurs för mig men jag gjorde mitt bästa.
här kommer en summerad feedback:
Bra jobbat med att tillgänglighets anpassa med skip to link och bra contrast - 99 på lighthouse snyggt!
Snyggt jobbat med designen och att du adderade ”experince & education” som en flik/filtrering gillar den idén och att du gjort acoordian knappar så man kan välja att se mer men ändå börja med en ”lagom” mängd info.
Bra jobbat med att följa designen och att göra sidan snygg på olika skärm storlekar
Cool animerad banner längst ner
Bra struktur av ditt content i json
har hittat lite små buggar som jag gett kommentarer om, men här är två småbuggar som jag var lite osäker över vart jag skulle skriva in:
Går inte att komma åt länk design figma i ”experience & education”
och en av projekten har ingen länk, är det medvetet?
tycker verkligen att det märkts att du lagt ner tid på att strukturera ditt arbeta och gör det på ett väldigt bra sätt!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wow utförlig readme! snygg struktur och hur det förklarar sidans upplägg och info om dig!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tack tack så mycket!! Värmer att höra :]
| <link rel="icon" type="image/svg+xml" href="/vite.svg" /> | ||
| <meta name="viewport" content="width=device-width, initial-scale=1.0" /> | ||
| <title>Portfolio</title> | ||
| <meta name="description" content="Daniel Lauding - Frontend Developer and Design Engineer. Portfolio showcasing React, TypeScript, and modern web development projects."> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seo tänk snyggt!
| <!-- Open Graph / Facebook --> | ||
| <meta property="og:type" content="website" /> | ||
| <meta property="og:url" content="https://lauding.se/" /> | ||
| <meta property="og:title" content="Daniel Lauding – Portfolio" /> | ||
| <meta property="og:description" content="Frontend Developer and Design Engineer. Portfolio showcasing React, TypeScript, and modern web development projects." /> | ||
| <meta property="og:image" content="https://lauding.se/avatar.png" /> | ||
| <meta property="og:image:width" content="1200" /> | ||
| <meta property="og:image:height" content="630" /> | ||
| <meta property="og:site_name" content="Daniel Lauding Portfolio" /> | ||
|
|
||
| <!-- Twitter --> | ||
| <meta name="twitter:card" content="summary_large_image" /> | ||
| <meta name="twitter:url" content="https://lauding.se/" /> | ||
| <meta name="twitter:title" content="Daniel Lauding – Portfolio" /> | ||
| <meta name="twitter:description" content="Frontend Developer and Design Engineer. Portfolio showcasing React, TypeScript, and modern web development projects." /> | ||
| <meta name="twitter:image" content="https://lauding.se/avatar.png" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bra gjort med implementation av og:tags, stretch goal!!
| <!-- Favicons --> | ||
| <link rel="icon" type="image/x-icon" href="/favicon/favicon.ico" /> | ||
| <link rel="icon" type="image/png" sizes="16x16" href="/favicon/favicon-16x16.png" /> | ||
| <link rel="icon" type="image/png" sizes="32x32" href="/favicon/favicon-32x32.png" /> | ||
| <link rel="icon" type="image/png" sizes="96x96" href="/favicon/favicon-96x96.png" /> | ||
|
|
||
| <!-- Apple Touch Icons --> | ||
| <link rel="apple-touch-icon" sizes="57x57" href="/favicon/apple-icon-57x57.png" /> | ||
| <link rel="apple-touch-icon" sizes="60x60" href="/favicon/apple-icon-60x60.png" /> | ||
| <link rel="apple-touch-icon" sizes="72x72" href="/favicon/apple-icon-72x72.png" /> | ||
| <link rel="apple-touch-icon" sizes="76x76" href="/favicon/apple-icon-76x76.png" /> | ||
| <link rel="apple-touch-icon" sizes="114x114" href="/favicon/apple-icon-114x114.png" /> | ||
| <link rel="apple-touch-icon" sizes="120x120" href="/favicon/apple-icon-120x120.png" /> | ||
| <link rel="apple-touch-icon" sizes="144x144" href="/favicon/apple-icon-144x144.png" /> | ||
| <link rel="apple-touch-icon" sizes="152x152" href="/favicon/apple-icon-152x152.png" /> | ||
| <link rel="apple-touch-icon" sizes="180x180" href="/favicon/apple-icon-180x180.png" /> | ||
| <link rel="apple-touch-icon" href="/favicon/apple-icon.png" /> | ||
|
|
||
| <!-- Android Icons --> | ||
| <link rel="icon" type="image/png" sizes="36x36" href="/favicon/android-icon-36x36.png" /> | ||
| <link rel="icon" type="image/png" sizes="48x48" href="/favicon/android-icon-48x48.png" /> | ||
| <link rel="icon" type="image/png" sizes="72x72" href="/favicon/android-icon-72x72.png" /> | ||
| <link rel="icon" type="image/png" sizes="96x96" href="/favicon/android-icon-96x96.png" /> | ||
| <link rel="icon" type="image/png" sizes="144x144" href="/favicon/android-icon-144x144.png" /> | ||
| <link rel="icon" type="image/png" sizes="192x192" href="/favicon/android-icon-192x192.png" /> | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
riktigt nogrann med olika favicons, bra jobbat
| if (!article) return null | ||
|
|
||
| const { title, excerpt, date, image, link } = article | ||
|
|
||
| const hasContent = title || excerpt || image | ||
| if (!hasContent) return null |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
najs error hantering
| const variants = { | ||
| default: { | ||
| bg: 'var(--bg-color)', | ||
| titleColor: 'var(--title-color)', | ||
| textColor: 'var(--text-color)', | ||
| }, | ||
| hero: { | ||
| bg: 'var(--section-hero-bg-color)', | ||
| titleColor: 'var(--section-hero-title-color)', | ||
| textColor: 'var(--section-hero-text-color)', | ||
| }, | ||
| tech: { | ||
| bg: 'var(--section-tech-bg-color)', | ||
| titleColor: 'var(--section-tech-title-color)', | ||
| textColor: 'var(--section-tech-text-color)', | ||
| }, | ||
| projects: { | ||
| bg: 'var(--section-projects-bg-color)', | ||
| titleColor: 'var(--section-projects-title-color)', | ||
| textColor: 'var(--section-projects-text-color)', | ||
| }, | ||
| articles: { | ||
| bg: 'var(--section-articles-bg-color)', | ||
| titleColor: 'var(--section-articles-title-color)', | ||
| textColor: 'var(--section-articles-text-color)', | ||
| }, | ||
| skills: { | ||
| bg: 'var(--section-skills-bg-color)', | ||
| titleColor: 'var(--section-skills-title-color)', | ||
| textColor: 'var(--section-skills-text-color)', | ||
| }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
gillar hur du gjort som en mall för styling för dem olika sektionerna
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
men undrar om det finns en anledning till att ha detta och samma i theme filen, eller har dem olika funktion?
| ], | ||
| "socialLinks": { | ||
| "linkedin": "https://www.linkedin.com/in/daniellauding/", | ||
| "github": "https://github.com/daniel-lauding", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
av någon anledning verkar inte länken ta mig till din profil utan står att jag hamnat fel - 404. kanske bara är en liten typo
| }, | ||
| { | ||
| "name": "Accessible Quiz Application", | ||
| "date": "2024", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
är det meningen att skolprojekten ska ha datum 2024?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
snyggt jobbat med att göra en theme och strukturera upp sektionerna, men som jag skrev innan är jag nyfiken på om denna och section.styled har olika funktion
| <header id="header"> | ||
| <SkipLink href="#main-content">Skip to main content</SkipLink> | ||
| <SkipLink href="#tech">Skip to technologies</SkipLink> | ||
| <SkipLink href="#projects">Skip to projects</SkipLink> | ||
| <SkipLink href="#articles">Skip to articles</SkipLink> | ||
| <SkipLink href="#skills">Skip to skills</SkipLink> | ||
| <SkipLink href="#cv">Skip to CV</SkipLink> | ||
| <SkipLink href="#footer">Skip to contact</SkipLink> | ||
|
|
||
| <Title as="h1" className="sr-only"> | ||
| Daniel Lauding - Frontend Developer Portfolio | ||
| </Title> | ||
|
|
||
| <Hero data={aboutData} /> | ||
| </header> | ||
| <main id="main-content"> | ||
| <TechStack data={stackData} /> | ||
| <Projects data={projectsData} /> | ||
| <Articles data={articlesData} /> | ||
| <Skills data={skillsData} /> | ||
| </main> | ||
| <Footer data={aboutData} /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
snygg struktur, men är nyfiken över om det är meningen att man ska hoppa över din inleding om dig själv med skip to main content och vart leder skip to CV, just nu funkar inte den länken, har du en sådan sektion?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hittade nu vad som är CV sektionen, att det är den som "delar" plats med projects. när man inte har Cv sektionen i klickad så kommer man ner till projekt sektionen men CV sektionen öppnas inte,så jag var lite förvirrad i början vad CV var när jag bara hade kollat browsern, vet inte själv hur man löser det men kan vara värt att kolla på
Portfolio website showcasing my work as a Frontend Developer and Design Engineer.
Features include: responsive design with dark/light theme toggle, scroll animations, accessible components (WCAG compliant), optimized performance (Lighthouse score 90+), and SEO-friendly with Open Graph tags.
Built with React, TypeScript, Styled Components, and Vite. Includes project showcases, articles, skills section, CV/experience timeline, and contact information.
Fully accessible with skip links, ARIA labels, and keyboard navigation. Optimized images, lazy loading, and code splitting for fast load times.
Netlify
Figma