Julia D. portfolio project #52
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Npahlfer
reviewed
Dec 12, 2025
| export const IconsSocMedia = () => { | ||
| return ( | ||
| <SocialWrapper> | ||
| <IconWithLink |
There was a problem hiding this comment.
Here you can loop out the social media links like this:
const soMe = [
{
link: 'https://github.com/Demijuls?tab=repositories',
image: '/icons/Btn - github.svg'
},
...
]
// And then in the jsx:
{soMe.map((item, index) => (
<IconWithLink
image={item.image}
link={item.link}
/>
))Then if you add more, you dont have to add any more elements. Or if you need to change something, you only need to change in one place! :)
Npahlfer
reviewed
Dec 12, 2025
| altText="preview picture for a project" | ||
| tags={data.tags} | ||
| about={data.about} | ||
| reverse={index % 2 === 1} |
Npahlfer
reviewed
Dec 12, 2025
| background-color: white; | ||
| } | ||
|
|
||
| @media (prefers-reduced-motion: reduce) { |
There was a problem hiding this comment.
Nice touch with turning off all the motion, when the user prefers it!
Npahlfer
reviewed
Dec 12, 2025
|
|
||
| ${media.mobile} { | ||
| p { | ||
| font-size: 18px !important; |
There was a problem hiding this comment.
the mobile breakpoint is not needed here as the tablet is max-width so it will cover the media as well :)
|
Overall good! Would have been nice to see some use of the theme file to reduce repetition of colors and fonts. Some repetition so think about how to keep it DRY through the use of components with props and looping out content :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please include a link to your Figma design and a Netlify link.