Handin/recipe libary #57
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… shows all recipes after clicking the random button, fixed the CSS styling, added a search function and implemented localStorage
JennieDalgren
left a comment
JennieDalgren
left a comment
There was a problem hiding this comment.
I can't find your netlify link anywhere?
| const sortPopSelect = document.getElementById("sortPop"); | ||
| const searchInput = document.getElementById("search"); | ||
|
|
||
| const renderStars = (num) => "⭐".repeat(num); |
Comment on lines
+12
to
+13
| const CACHE_KEY = "recipesCache"; // localStorage key | ||
| const CACHE_TIME = 6 * 60 * 60 * 1000; // 6 hours in ms |
Comment on lines
+81
to
+89
| const query = searchQuery.trim().toLowerCase(); | ||
| if (query) { | ||
| list = list.filter((r) => { | ||
| const inTitle = (r.title || "").toLowerCase().includes(query); | ||
| const inIngredients = (r.ingredients || []).some((i) => | ||
| (i || "").toLowerCase().includes(query) | ||
| ); | ||
| return inTitle || inIngredients; | ||
| }); |
Comment on lines
+118
to
+120
| if (list.length === 0) { | ||
| cardsEl.innerHTML = `<p>No recipes found. Try another filter</p>`; | ||
| return; |
| // Get the diet type (vegan, vegetarian, etc.) | ||
| const dietText = r.diet; | ||
| // Convert popularity score into stars | ||
| const popularText = renderStars(r.popularity); |
Comment on lines
+136
to
+137
| const ingHtml = r.ingredients.map((i) => `<li>${i}</li>`).join(""); //Här görs igridienslistan om från array till html | ||
|
|
Comment on lines
+174
to
+185
| <article class="recipe"> | ||
| <img src="${r.img}" alt="${r.title}" /> | ||
| <h3 class="title">${r.title}</h3> | ||
| <div class="meta"> | ||
| <p><strong>Cuisine:</strong> <span class="cuisine">${cuisineText}</span></p> | ||
| <p><strong>Diet:</strong> <span>${dietText}</span></p> | ||
| <p><strong>Popularity:</strong>${popularText}</p> | ||
| <p><strong>Time:</strong> <span>${timeText}</span></p> | ||
| </div> | ||
| <h4>Ingredients</h4> | ||
| <ul>${ingHtml}</ul> | ||
| </article> |
There was a problem hiding this comment.
be thorough with indentation of html even inside of js
| cardsEl.innerHTML = renderSingleResult(recipe); | ||
|
|
||
| // Reveal the "Show all" button so the user can restore the list | ||
| showAllButton.style.display = "inline-block"; |
Comment on lines
+235
to
+240
| const saved = JSON.parse(cached); | ||
| const tooOld = Date.now() - saved.timestamp > CACHE_TIME; | ||
|
|
||
| // Use cached recipes and render immediately | ||
| if (!tooOld) { | ||
| cardsEl.innerHTML = "<p>Showing recipes from cache</p>"; |
There was a problem hiding this comment.
Nice! very good use of a timed cache
Comment on lines
+271
to
+284
| switch (error.message) { | ||
| case "401": | ||
| message = "<p>Invalid or missing API key (401).</p>"; | ||
| break; | ||
| case "402": | ||
| case "429": | ||
| message = ` | ||
| <p>You have reached your daily API quota or are rate-limited (402/429).</p> | ||
| <p>Try again tomorrow, reduce requests, or use cached data.</p> | ||
| `; | ||
| break; | ||
| default: | ||
| message = | ||
| "<p>Could not fetch recipes right now. Please try again later.</p>"; |
|
never mind, I just saw that I reviewed your other PR already! :D |
Author
|
Great! So you find the link?
…________________________________
From: Jennie Dalgren ***@***.***>
Sent: Thursday, October 23, 2025 11:36:07 PM
To: Technigo/js-project-recipe-library ***@***.***>
Cc: AgnesSj01 ***@***.***>; Author ***@***.***>
Subject: Re: [Technigo/js-project-recipe-library] Handin/recipe libary (PR #57)
[https://avatars.githubusercontent.com/u/18549785?s=20&v=4]JennieDalgren left a comment (Technigo/js-project-recipe-library#57)<#57 (comment)>
never mind, I just saw that I reviewed your other PR already! :D
Remember, you don't need to open PR more than once. It will update if you update. And multiple persons can feedback on it.
—
Reply to this email directly, view it on GitHub<#57 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/BMAXIAQAHCS2QQNAKRG2HR33ZFC4PAVCNFSM6AAAAACI2I5B7KVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTIMZZGMYTMMJZGQ>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.