Books API #519
Open
Books API #519
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HIPPIEKICK
approved these changes
Dec 10, 2024
Contributor
HIPPIEKICK
left a comment
HIPPIEKICK
left a comment
There was a problem hiding this comment.
Well done Gitte! Your API is RESTful (however, I would put the popular filter on the /books endpoint as well, but given you had two other query params there, I see you get the concept) and well-documented.
Keep up the good work!
Comment on lines
+26
to
29
| app.get("/books/popular", (req, res) => { | ||
| const popularBooks = booksData.filter(book => book.average_rating && parseFloat(book.average_rating) > +4) | ||
| res.status(200).json(popularBooks) | ||
| }); |
Contributor
There was a problem hiding this comment.
This could be a query param: ?popular=true
|
|
||
| // author and title | ||
| app.get("/books", (req, res) => { | ||
| const { title, author } = req.query; |
Comment on lines
+60
to
+70
| app.get("/books/:isbn", (req, res) => { | ||
| const isbn = req.params.isbn | ||
| const book = booksData.find(book => book.isbn === +isbn) | ||
| res.json(book); { | ||
| if (book) { | ||
| res.status(200).json(book) | ||
| } else { | ||
| res.status(404).send("no book found with that ISBN") | ||
| } | ||
| } | ||
| }) |
|
Congrats Gitte! Really good job with the nice, clean and super-easy-to-follow code! I learn a lot from your code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://project-express-api-17pi.onrender.com