Skip to content

Fixed typo in the ctor that would throw NullReferenceException for un… #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zbalkan wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixed typo in the ctor that would throw NullReferenceException for un… #54

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion TechnitiumLibrary.Security.OTP/Authenticator.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ public class Authenticator
public Authenticator(AuthenticatorKeyUri keyUri)
{
Copy link

Copilot AI Feb 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Authenticator(AuthenticatorKeyUri keyUri) dereferences keyUri before validating it; passing null will still throw a NullReferenceException at keyUri.Type. Consider adding ArgumentNullException.ThrowIfNull(keyUri) at the start (consistent with other constructors like AuthenticatorKeyUri and DomainEndPoint).

Suggested change
{
{
ArgumentNullException.ThrowIfNull(keyUri);

Copilot uses AI. Check for mistakes.
if (!keyUri.Type.Equals("totp", StringComparison.OrdinalIgnoreCase))
throw new NotSupportedException($"The authenticator key URI type '{_keyUri.Type}' is not supported.");
throw new NotSupportedException($"The authenticator key URI type '{keyUri.Type}' is not supported.");

_keyUri = keyUri;
_key = Base32.FromBase32String(_keyUri.Secret);
Expand Down
Loading