Skip to content

Conversation

@liweijie0812
Copy link
Collaborator

🤔 这个 PR 的性质是?

  • 日常 bug 修复
  • 新特性提交
  • 文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • CI/CD 改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他

🔗 相关 Issue

💡 需求背景和解决方案

📝 更新日志

  • fix(组件名称): 处理问题或特性描述 ...

  • 本条 PR 不需要纳入 Changelog

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

@pkg-pr-new
Copy link

pkg-pr-new bot commented Dec 4, 2025

Open in StackBlitz

npm i https://pkg.pr.new/Tencent/tdesign/@tdesign/site-components@769
npm i https://pkg.pr.new/Tencent/tdesign/@tdesign/theme-generator@769

commit: 503df44

@tdesign-bot
Copy link
Collaborator

tdesign-bot commented Dec 4, 2025

TDesign Component Site Preview CI Open

Sites (8)
Component Preview
tdesign-site 完成
tdesign-vue 完成
tdesign-react 完成
tdesign-vue-next 完成
@tdesign-vue-next/chat 完成
tdesign-mobile-vue 完成
tdesign-mobile-react 完成
tdesign-miniprogram 完成

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a min-height: 480px property to the .tdesign-toc_container (Table of Contents container) in the documentation styles. However, this creates a logical conflict with the existing responsive max-height property.

Key Changes

  • Added min-height: 480px to the TOC container styling

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

width: 240px;
padding-right: 10px;
max-height: 480px;
min-height: 480px;
Copy link

Copilot AI Dec 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Setting min-height: 480px creates a conflict with the max-height on the next line. The max-height uses min(calc(100vh - 550px), 480px), which means when the viewport height is less than 1030px (550px + 480px), the max-height will be less than 480px, but min-height enforces a minimum of 480px. This results in min-height overriding max-height, which defeats the purpose of the responsive max-height calculation.

Consider removing this min-height property, or adjusting the logic so that min-height is always less than or equal to the possible max-height values.

Suggested change
min-height: 480px;

Copilot uses AI. Check for mistakes.
@liweijie0812 liweijie0812 force-pushed the style/tdesign-toc_container/min-height branch from ebabd0c to 9a538d1 Compare December 8, 2025 09:06
@liweijie0812 liweijie0812 force-pushed the style/tdesign-toc_container/min-height branch from 9a538d1 to 503df44 Compare December 8, 2025 09:37
@liweijie0812 liweijie0812 changed the title style(tdesign-toc_container): add min-height style(tdesign-toc_container): fix max-height Dec 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants