-
Notifications
You must be signed in to change notification settings - Fork 303
style(tdesign-toc_container): fix max-height #769
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
commit: |
TDesign Component Site Preview CI Open |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds a min-height: 480px property to the .tdesign-toc_container (Table of Contents container) in the documentation styles. However, this creates a logical conflict with the existing responsive max-height property.
Key Changes
- Added
min-height: 480pxto the TOC container styling
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| width: 240px; | ||
| padding-right: 10px; | ||
| max-height: 480px; | ||
| min-height: 480px; |
Copilot
AI
Dec 4, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Setting min-height: 480px creates a conflict with the max-height on the next line. The max-height uses min(calc(100vh - 550px), 480px), which means when the viewport height is less than 1030px (550px + 480px), the max-height will be less than 480px, but min-height enforces a minimum of 480px. This results in min-height overriding max-height, which defeats the purpose of the responsive max-height calculation.
Consider removing this min-height property, or adjusting the logic so that min-height is always less than or equal to the possible max-height values.
| min-height: 480px; |
ebabd0c to
9a538d1
Compare
9a538d1 to
503df44
Compare

🤔 这个 PR 的性质是?
🔗 相关 Issue
💡 需求背景和解决方案
📝 更新日志
fix(组件名称): 处理问题或特性描述 ...
本条 PR 不需要纳入 Changelog
☑️ 请求合并前的自查清单