Conversation
# Conflicts: # package.json
Also remove appBaseUrl default
# Conflicts: # package-lock.json # package.json # yarn.lock
Contributor
Author
|
OK @kring this is ready now, I don't know if we want travis to attempt prerendering as part of the build or just skip it for CI:
Working CI test can be seen @ #349 - the only material difference is pointing to the right |
soyarsauce
commented
Jun 26, 2019
| <!DOCTYPE html> | ||
| <html lang="en" class="terria"> | ||
| <head> | ||
| <base href="/"> |
Contributor
Author
There was a problem hiding this comment.
Actually now index.html gets updated as part of the render-datasource-templates gulp task, should we remove this from source to avoid confusion?
Member
|
to redev/review after mobx |
# Conflicts: # package.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See: TerriaJS/terriajs#3494
Still to do
generate-init-routes.jsAlso see:
TerriaJS/terriajs-server#106