Remove invalid option disable for mini-css-extract-plugin.#701
Closed
Remove invalid option disable for mini-css-extract-plugin.#701
disable for mini-css-extract-plugin.#701Conversation
pjonsson
approved these changes
Oct 22, 2024
Contributor
pjonsson
left a comment
pjonsson
left a comment
There was a problem hiding this comment.
I think the PR that depends on this fixes security issues in dependencies, so definitely want this.
Contributor
|
@na9da my understanding is that there is no visible effect from merging this since the options are unused, but this PR has still been sitting for a month. Is there anything preventing it from getting merged? |
Contributor
|
I think this can be closed now since #718 is merged. |
Collaborator
|
this seems to be resolved as part of webpack 5 upgrade |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TerriaJS PR TerriaJS/terriajs#7210 upgrades style-loader and mini-css-extract-plugin from really old versions to latest ones compatible with webpack. They have strict checks for invalid options.
disableandallChunksappears to be options from a previous version of the plugin called extract-text-webpack-plugin which is not valid formini-css-extract-plugin.This change to terriamap is required before merging #7210.