Open
Conversation
pjonsson
commented
Feb 15, 2025
| "docker-build-ci": "node deploy/docker/create-docker-context.js --build", | ||
| "start": "terriajs-server --config-file serverconfig.json", | ||
| "gulp": "gulp", | ||
| "postinstall": "echo 'Installation successful. What to do next:\\n yarn gulp dev # Starts the server on port 3001, builds TerriaMap and dependencies, and rebuilds if files change.'", |
Contributor
Author
There was a problem hiding this comment.
The wording in the yarn documentation is quite strong to avoid postinstall scripts (https://v3.yarnpkg.com/advanced/lifecycle-scripts#a-note-about-postinstall), and since this is just an echo statement I removed it.
pjonsson
commented
Feb 15, 2025
| "packages/plugin-api", | ||
| "packages/plugin-sample" | ||
| ], | ||
| "nohoist": [ |
Contributor
Author
There was a problem hiding this comment.
This has moved to the nmHoistingLimits in yarnrc.yml. Someone who uses workspaces should test that it still works as intended.
pjonsson
added a commit
to pjonsson/terriajs
that referenced
this pull request
Feb 16, 2025
This mirrors the TerriaMap PR: TerriaJS/TerriaMap#728 Fixes TerriaJS#6453
4 tasks
pjonsson
added a commit
to pjonsson/terriajs
that referenced
this pull request
Feb 16, 2025
This mirrors the TerriaMap PR: TerriaJS/TerriaMap#728 Fixes TerriaJS#6453
pjonsson
added a commit
to pjonsson/terriajs
that referenced
this pull request
Feb 16, 2025
This mirrors the TerriaMap PR: TerriaJS/TerriaMap#728 Fixes TerriaJS#6453
pjonsson
force-pushed
the
update-to-yarn-v2
branch
from
fe8cdf6 to
2ad90a6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on: #718 (upgrade to node 20+)
Link to documentation on why to upgrade: https://yarnpkg.com/getting-started/qa#why-should-you-upgrade-to-yarn-modern
Fixes #705