Conversation
There is no "terriajs" directory in this repository, so import tsconfig.json from the terriajs directory inside node_modules instead, just like the ESLint configuration does. This requires re-defining outDir, typeRoots, and include to the same values that they have in terriajs, since they will otherwise be relative to the node_modules tsconfig.json. The types option requires including a couple of lib/ThirdParty directories in terriajs. The maxNodeModuleJsDepth parameter is required for not getting errors about implicit any types on jsx imports in terriajs source code.
|
There is no need for this, as typescript will use node resolution to resolve the file, and having it use a relative path might cause issues for others using Terriamap in a non-standard way (someone installed terriamap and terriajs as dep, it will put terriajs at different place and break it). |
How can the type error fixed by #729 pass the CI if this isn't needed? |
|
I don't understand what kind of type error you get in #729 in CI; from what I see, that PR passes the CI. |
|
I'm not saying that this PR is necessarily the right fix, but my point is that the function expects two parameters: and that isn't caught by the CI. I also don't get a type error when I run |
Depends on: #729
There is no "terriajs" directory
in this repository, so import
tsconfig.json from the terriajs
directory inside node_modules
instead, just like the ESLint
configuration does.
This requires re-defining outDir,
typeRoots, and include to the same
values that they have in terriajs,
since they will otherwise be relative
to the node_modules tsconfig.json.
The types option requires including
a couple of lib/ThirdParty directories
in terriajs.
The maxNodeModuleJsDepth parameter
is required for not getting errors
about implicit any types on jsx
imports in terriajs source code.