Extract text from globe.gif to Loader.tsx#763
Open
pchepelev wants to merge 1 commit intoTerriaJS:mainfrom
Open
Extract text from globe.gif to Loader.tsx#763pchepelev wants to merge 1 commit intoTerriaJS:mainfrom
pchepelev wants to merge 1 commit intoTerriaJS:mainfrom
Conversation
niktayv
reviewed
Aug 26, 2025
| import globeGif from "../Styles/globe.gif"; | ||
| import Styles from "./loader.scss"; | ||
|
|
||
| const loadingStr = "Loading the globe"; |
Collaborator
There was a problem hiding this comment.
Literal strings should be defined in translations. See languageOverrides.json.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the text from the
globe.gifimage and displays the removed string inLoader.tsx. The string is not translated, and is hard coded in that file as I could not find any translation files in this project. If there is any suggestion as to where to put this string, or if I should create something new, let me know.I removed some rules in
loader.scssas they were interfering with my changes, or they had no effect. Those removed rules were added a long time ago so I think it is safe to remove them.I tested this on Chrome, Firefox and Edge, and at various window sizes and it looks consistent.
The loader now looks like this:
