Skip to content

Fix navbar children assigned to multiple parents due to missing unique column IDs #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix navbar children assigned to multiple parents due to missing unique column IDs #96

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion commit/commit/doctype/commit_docs/commit_docs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -456,7 +456,7 @@ def manage_navbar(commit_doc:str, navbar_items, sub_navbar_items=None):
})
if sub_navbar_items:
# find the task in the sub_navbar_items where columnId is equal to item.get('label')
sub_items = [sub_item for sub_item in sub_navbar_items if sub_item.get('columnId') == item.get('label')]
sub_items = [sub_item for sub_item in sub_navbar_items if sub_item.get('columnId') == item.get('id')]
# sort the sub_items by index field
sub_items = sorted(sub_items, key=lambda x: x.get('index', 0))
# Loop Over the Sub Items
Expand Down
2 changes: 1 addition & 1 deletion dashboard/src/pages/features/docs/Navbar/NavbarBoard.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -358,7 +358,7 @@ const CreateNewParentLabel = ({ onColumnCreate, onClose, open }: CreateParentLab
if (!prev) {
// Initialize the column object if it's null
return {
id: '', // Provide a default value for required fields
id: crypto.randomUUID(), // Generate a unique ID
type: 'Button', // Default type
label: '',
url: '',
Expand Down