Skip to content

fix: check winboat disk space instead of its parent path #418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
+15 −1
Draft

fix: check winboat disk space instead of its parent path #418

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion src/renderer/views/SetupUI.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -943,8 +943,22 @@ const installFolderErrors = computedAsync(async () => {
errors.push("The selected install location is not writable");
}

// Create /winboat
const winboatPath = path.join(parentPath, "winboat");
const isWinboatPathCreated = false;
try {
fs.mkdirSync(winboatPath, { recursive: true });
isWinboatPathCreated = true;
Copy link
Collaborator

@waffles-dev waffles-dev Oct 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how does this work when isWinboatPathCreated is a constant?

Copy link
Author

@GetPsyched GetPsyched Oct 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops. That bool was a last-minute thing so it went untested

console.log("Created winboat directory at", winboatPath);
} catch (err) {
console.error(err);
}

// Check if we have enough disk space
const diskSpace = await checkDiskSpace(parentPath);
const diskSpace = await checkDiskSpace(isWinboatPathCreated ? winboatPath : parentPath);
if (isWinboatPathCreated) {
await fs.rm(winboatPath, { recursive: true });
Copy link
Collaborator

@waffles-dev waffles-dev Oct 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Error: Object literal may only specify known properties, and 'recursive' does not exist in type 'NoParamCallback`

Copy link
Author

@GetPsyched GetPsyched Oct 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting; where are you seeing this error? I had a lot of trouble seeing any errors. I had to rely solely on if things worked or not.

}
const freeGB = Math.floor(diskSpace.free / (1024 * 1024 * 1024));
if (freeGB < MIN_DISK_GB) {
errors.push(
Expand Down