feat: Fix issues before release 0.9.0 #463
Draft
+47
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chore: Revert runtime-based container names
waffles-dev
approved these changes
Nov 7, 2025
waffles-dev
reviewed
Nov 8, 2025
waffles-dev
reviewed
Nov 8, 2025
Closed
Co-authored-by: waffles-dev <[email protected]>
chore: Add color rule for Creatd container state chore: Remove type assertion and @ts-expect-error using Reflect.set
Contributor
|
PR #413 forgot about adding |
waffles-dev
requested changes
Nov 9, 2025
| multiMonitor: 0, | ||
| rdpArgs: [], | ||
| disableAnimations: false, | ||
| containerRuntime: ContainerRuntimes.DOCKER, // TODO: Ideally should be podman once we flesh out everything |
Collaborator
There was a problem hiding this comment.
Put comment on line above
Suggested change
| containerRuntime: ContainerRuntimes.DOCKER, // TODO: Ideally should be podman once we flesh out everything | |
| // TODO: Ideally should be podman once we flesh out everything | |
| containerRuntime: ContainerRuntimes.DOCKER, |
| logger.info("Performing migrations for 0.9.0"); | ||
|
|
||
| // Compose migration | ||
| this.containerMgr!.exists().then(async (value) => { |
Collaborator
There was a problem hiding this comment.
getting warnings for async within constructor
| logger.info("Performing migrations for 0.9.0"); | ||
|
|
||
| // Compose migration | ||
| this.containerMgr!.exists().then(async (value) => { |
Collaborator
There was a problem hiding this comment.
In regards to the !:
"This assertion is unnecessary since it does not change the type of the expression"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to fix some issues in the current HEAD of WinBoat before the next release.
I'll be going through and testing migrations, features, etc. and pushing the fixes here.