feat: check for server nickname property#658
Open
moses-codes wants to merge 2 commits intoTogether-100Devs:mainfrom
Open
feat: check for server nickname property#658moses-codes wants to merge 2 commits intoTogether-100Devs:mainfrom
moses-codes wants to merge 2 commits intoTogether-100Devs:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is a version of the pull request feature-#482, which accumulated too much git history; this version has only the commits related to that pull request.
This PR searches for a user's nickname within the 100Devs server, and displays it if such a property exists.
Also contains unit tests for the feature.
Type of change
Please select everything applicable. Please, do not delete any lines.
Issue
Checklist:
npm run testandnpm run test:e2eand all tests have passed successfully or I have included details within my PR on the failure.npm run lintand resolved any outstanding errors. Most issues can be solved by executingnpm run format