theme background applied for swift ui sections #1451
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR fixes missing theme backgrounds in multiple SwiftUI sections across the app by applying consistent theming to list rows and view backgrounds. The changes ensure visual consistency across different parts of the settings, profile, and search views by standardizing the use of theme colors.
Changes:
- Added
.listRowBackground(theme.tertiarySystemBackgroundColor)to Section views across Settings, Profile, and related screens - Changed background colors from
theme.systemGroupedBackgroundColortotheme.systemBackgroundColorfor overall view backgrounds - Added
@EnvironmentObjecttheme references to views that needed access to the theme for new background modifiers - Converted
SettingsPlayerControlsViewfrom Form to List for consistency with other theme-related settings views
Reviewed changes
Copilot reviewed 44 out of 44 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| BookPlayer/Settings/Themes/SettingsThemesView.swift | Added list row backgrounds and changed overall background color |
| BookPlayer/Settings/Storage/StorageView.swift | Added list row backgrounds to sections and changed overall background color |
| BookPlayer/Settings/Storage/StorageCloudDeletedView.swift | Added list row backgrounds to sections and changed overall background color |
| BookPlayer/Settings/Storage/SettingsStorageSectionView.swift | Added list row background to section |
| BookPlayer/Settings/Storage/SettingsDataUsageSectionView.swift | Added list row background to section |
| BookPlayer/Settings/SettingsView.swift | Changed overall background color from systemGroupedBackgroundColor to systemBackgroundColor |
| BookPlayer/Settings/Sections/SettingsiCloudSectionView.swift | Added list row background to section |
| BookPlayer/Settings/Sections/SettingsTipOptionsView.swift | Added theme environment object and backgrounds to tip views |
| BookPlayer/Settings/Sections/SettingsTipJarView.swift | Changed overall background color |
| BookPlayer/Settings/Sections/SettingsSupportSectionView.swift | Added list row background to section |
| BookPlayer/Settings/Sections/SettingsShortcutsSectionView.swift | Added list row background to section |
| BookPlayer/Settings/Sections/SettingsProBannerSectionView.swift | Added list row background to section |
| BookPlayer/Settings/Sections/SettingsPrivacySectionView.swift | Added list row background to section |
| BookPlayer/Settings/Sections/SettingsPlaybackSectionView.swift | Added list row background to section |
| BookPlayer/Settings/Sections/SettingsIntegrationsSectionView.swift | Added list row background to section |
| BookPlayer/Settings/Sections/SettingsCreditsSectionView.swift | Added list row background to section |
| BookPlayer/Settings/Sections/SettingsAppearanceSectionView.swift | Added list row background to section |
| BookPlayer/Settings/Sections/PlayerControls/SmartRewindSectionView.swift | Added list row background to section |
| BookPlayer/Settings/Sections/PlayerControls/SkipIntervalsSectionView.swift | Added list row background to section |
| BookPlayer/Settings/Sections/PlayerControls/SettingsPlayerControlsView.swift | Converted Form to List, added list row backgrounds (with duplicate modifier issue) |
| BookPlayer/Settings/Sections/PlayerControls/ProgressSeekingSectionView.swift | Added list row background to section |
| BookPlayer/Settings/Sections/PlayerControls/ProgressLabelsSectionView.swift | Added list row background to section |
| BookPlayer/Settings/Sections/PlayerControls/ListOptionsSectionView.swift | Added list row background to section |
| BookPlayer/Settings/Sections/PlayerControls/GlobalSpeedSectionView.swift | Added list row background to section |
| BookPlayer/Settings/Sections/PlayerControls/BoostVolumeSectionView.swift | Added list row background to section |
| BookPlayer/Settings/Sections/PlayerControls/AutoSleepTimerSectionView.swift | Added list row background to section |
| BookPlayer/Settings/Icons/SettingsAppIconsView.swift | Added list row background and changed overall background color |
| BookPlayer/Settings/Autoplay/SettingsAutoplayView.swift | Added list row background and changed overall background color |
| BookPlayer/Settings/Autolock/SettingsAutolockView.swift | Added list row background and changed overall background color |
| BookPlayer/Search/SearchView.swift | Changed overall background color |
| BookPlayer/Profile/Profile/QueuedSyncTasksView.swift | Changed overall background color |
| BookPlayer/Profile/Profile/ProfileView.swift | Changed overall background color and added redundant environmentObject call |
| BookPlayer/Profile/Profile/ProfileCardSectionView.swift | Added theme environment object and list row background |
| BookPlayer/Profile/Account/AccountView.swift | Changed overall background color |
| BookPlayer/Profile/Account/AccountTermsConditionsSectionView.swift | Added list row background to section |
| BookPlayer/Profile/Account/AccountPasskeySectionView.swift | Added list row background to section |
| BookPlayer/Profile/Account/AccountManageProSectionView.swift | Added list row background to section |
| BookPlayer/Profile/Account/AccountLogoutSectionView.swift | Added list row background to section |
| BookPlayer/Profile/Account/AccountDeleteSectionView.swift | Added list row background to section |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| .scrollContentBackground(.hidden) | ||
| .background(theme.systemBackgroundColor) | ||
| .listRowBackground(theme.systemGroupedBackgroundColor) | ||
| .listRowBackground(theme.systemBackgroundColor) |
There was a problem hiding this comment.
There are duplicate .listRowBackground() modifiers on lines 25 and 29. The modifier at line 25 sets the background to theme.tertiarySystemBackgroundColor which is applied to the List, but then line 29 overrides it with theme.systemBackgroundColor. This creates conflicting background settings and the second modifier will override the first one. Remove one of these duplicate modifiers - likely the one at line 29 should be removed to maintain consistency with other files in this PR.
Suggested change
| .listRowBackground(theme.systemBackgroundColor) |
| } | ||
| .foregroundStyle(theme.primaryColor) | ||
| .tint(theme.linkColor) | ||
| .environmentObject(theme) |
There was a problem hiding this comment.
This .environmentObject(theme) call is redundant since the theme is already available as an @EnvironmentObject property at line 17. The environment object is already being passed down from the parent view, so this line unnecessarily passes it again. Remove this line to avoid redundancy.
Suggested change
| .environmentObject(theme) |
GianniCarlo
approved these changes
Feb 7, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bugfix
Approach
Things to be aware of / Things to focus on
theme.tertiarySystemBackgroundColorwas the best match for the itemsScreenshots