Skip to content

Hero component text selection and image dragging fixes. #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AbbyHoyt wants to merge 2 commits into
base: 2025Rework
Choose a base branch
from
Open

Hero component text selection and image dragging fixes. #91

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1ccb3b1
Fixed officer image dragging and background color for scroll/overflow.
AbbyHoyt Jan 31, 2026
4cbf8dc
Disabled text select and image dragging for hero component.
AbbyHoyt Jan 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 1 addition & 25 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 5 additions & 1 deletion src/_variables.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,4 +28,8 @@ h1, h2, h3 {
font-family: $font-heading;
text-transform: uppercase;
font-weight: 600;
}
}

body {
background-color: $EerieBlack;
}
2 changes: 1 addition & 1 deletion src/components/Hero/Hero.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ export const Hero = () => {
<img src={roverOnRock} alt="Viator rover" className='background-image'/>

<MaxWidthContainer>
<img src={watermelonDragon} alt="Watermelon dragon mascot" className='watermelonDragon'/>
<img src={watermelonDragon} alt="Watermelon dragon mascot" className='watermelonDragon' draggable="false"/>
<div className='text'>
<h1 className='title'>TrickFire Robotics</h1>
<p className='subtitle'>Developing future engineers, developers, and marketers in the world of competitive robotics</p>
Expand Down
4 changes: 4 additions & 0 deletions src/components/Hero/Hero.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,10 @@
justify-content: center;
height: 80vh;
padding: 0 3rem;
user-select: none;
-webkit-user-select: none;
-moz-user-select: none;
-ms-user-select: none;

.max-width-container {
display: flex;
Expand Down
2 changes: 1 addition & 1 deletion src/components/Officer/Officer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ import './Officer.scss'
export const Officer = ({image, name, position}) => {
return (
<div className='officer-box'>
<img className='image' src={image} alt={name} />
<img className='image' src={image} alt={name} draggable="false"/>
<div className='overlay'>
<p className='officer-name'>{name}</p>
<p className='officer-position'>{position}</p>
Expand Down