-
Notifications
You must be signed in to change notification settings - Fork 27
feat: add support for priority classes #413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
sym-stiller
wants to merge
16
commits into
TykTechnologies:main
Choose a base branch
from
sym-stiller:feat/priority-class
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat: add support for priority classes #413
sym-stiller
wants to merge
16
commits into
TykTechnologies:main
from
sym-stiller:feat/priority-class
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7041192 to
3b62d0b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
These changes enable users of the Tyk Helm charts to specify a
priorityClassNamefor each component. By default, no priority class is assigned to the components.Related Issue
#411
Motivation and Context
When no priority class is specified, Kubernetes will assign the lowest possible priority to pods. These low-priority pods may be preempted by higher-priority pods, which is not ideal for an API gateway.
Test Coverage For This Change
I have templated the charts locally like this:
Types of changes
Checklist
master!masterbranch (left side). Also, it would be best if you started your change off our latestmaster.