Skip to content

Completely remove coroutines#3659

Merged
StarrryNight merged 4 commits intomasterfrom
completely_remove_coroutines
Mar 29, 2026
Merged

Completely remove coroutines#3659
StarrryNight merged 4 commits intomasterfrom
completely_remove_coroutines

Conversation

@StarrryNight
Copy link
Copy Markdown
Contributor

Description

This PR resolves #2359 . It removes all dead code from the old play structure using coroutines. This includes removing functions like getNextTactic, getNextTacticWrapper etc. update Tactics is also converted to a a pure virtual function, and its declaration is removed in play_base.cpp.

In addition, docs related to coroutines are also removed. Although cpp tests use coroutines, they are also being removed in #3632.

Testing Done

All tests pass. Thunderscope runs like before.

Resolved Issues

#2359

Length Justification and Key Files to Review

Review Checklist

It is the reviewers responsibility to also make sure every item here has been covered

  • Function & Class comments: All function definitions (usually in the .h file) should have a javadoc style comment at the start of them. For examples, see the functions defined in thunderbots/software/geom. Similarly, all classes should have an associated Javadoc comment explaining the purpose of the class.
  • Remove all commented out code
  • Remove extra print statements: for example, those just used for testing
  • Resolve all TODO's: All TODO (or similar) statements should either be completed or associated with a github issue

sauravbanna
sauravbanna previously approved these changes Mar 25, 2026
Copy link
Copy Markdown
Contributor

@sauravbanna sauravbanna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm !

Copy link
Copy Markdown
Contributor

@Andrewyx Andrewyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@StarrryNight StarrryNight merged commit 2d65fc7 into master Mar 29, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Clean up Coroutines after transitioning Plays to FSMs

4 participants