-
Notifications
You must be signed in to change notification settings - Fork 1
9주차-미션 앤디/박영찬 #21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
zerochani
wants to merge
61
commits into
main
Choose a base branch
from
앤디/박영찬
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
9주차-미션 앤디/박영찬 #21
The head ref may contain hidden characters: "\uC564\uB514/\uBC15\uC601\uCC2C"
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Store owner 매핑을 member_id로 수정 - MemberFoodPreference에 BaseTimeEntity 상속 추가 - Photo 엔티티 Builder 패턴 정리
- JPQL @query방식으로 중복 리뷰 체크 - ReviewService에 리뷰 작성 로직 구현 - MemberRepository, StoreRepository 추가
- @TestPropertySource로 H2 데이터베이스 설정 추가 - H2 의존성 추가로 빌드 실패 문제 해결
- ErrorCode enum 및 BusinessException 구현 - GlobalExceptionHandler로 전역 예외 처리 - ErrorResponse DTO로 일관된 에러 응답 제공 - ReviewService 예외 처리 개선
- MemberService 및 getMyPage 메서드 추가 - MyPageResponse DTO 생성 - ReviewRepository에 countByMemberId 메서드 추가 - InquiryRepository 생성 및 countByMemberId 메서드 추가 - NotificationSettingRepository 생성 및 findByMemberId 메서드 추가
- 메서드 이름 생성 방식에서 @query로 변경 -연관 엔티티의 속성 접근 시 JPQL 사용으로 일관성 확보
- Mission, Store 엔티티의 일대다 컬렉션에 @batchsize 적용 - N+1 문제 방지 및 메모리 페이징 문제 예방
…조회 기능 구현 - ReviewResponse 미션형식으로 개선
- ApiResponse로 성공/실패 응답 구조 통합 - SuccessCode에 HttpStatus 추가하여 ErrorCode와 구조 통일 - GlobalExceptionHandler의 모든 예외를 ApiResponse로 통일 - ReviewController에 SuccessCode 적용
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
9주차 미션 완료했습니다!