Conversation
…pdated docstrings in 'MCSim_model.R', and updated version number in 'DESCRIPTION'.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses path handling issues on Windows, improves documentation clarity, and prepares for a new release. The changes focus on fixing a bug with spaces in Windows paths by reintroducing path normalization logic, updating method documentation to accurately describe their reset-then-update behavior, and bumping the version number.
Changes:
- Fixed Windows path handling to support spaces by converting to short path names
- Corrected typo in comment ("generate" → "generated")
- Enhanced docstrings for
updateParms()andupdateY0()to clarify that they reset to defaults before applying updates - Bumped version from 1.1.9000 to 1.2
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| R/fixPath.R | Adds Windows-specific path normalization using shortPathName() and fixes typo in comment |
| R/MCSim_model.R | Updates docstrings to clarify reset-then-update behavior of parameter and state update methods |
| man/Model-class.Rd | Updates documentation to match improved docstrings in source code |
| DESCRIPTION | Updates package version to 1.2 for release |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.